This is an automated email from the ASF dual-hosted git repository.
chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new c53c5717676 MINOR: Makes `LogCleaner.CleanerThread` a `final` class.
(#20660)
c53c5717676 is described below
commit c53c571767611e52b409c421caf625d9cf5a3400
Author: Maros Orsak <[email protected]>
AuthorDate: Mon Oct 20 19:22:35 2025 +0200
MINOR: Makes `LogCleaner.CleanerThread` a `final` class. (#20660)
This inner class is not designed for extension, and making it `final`
improves clarity and maintainability.
The redundant `@SuppressWarnings("this-escape")` is also removed.
Reviewers: Chia-Ping Tsai <[email protected]>
---
.../main/java/org/apache/kafka/storage/internals/log/LogCleaner.java | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
a/storage/src/main/java/org/apache/kafka/storage/internals/log/LogCleaner.java
b/storage/src/main/java/org/apache/kafka/storage/internals/log/LogCleaner.java
index 19240cce0c5..19f973c29fb 100644
---
a/storage/src/main/java/org/apache/kafka/storage/internals/log/LogCleaner.java
+++
b/storage/src/main/java/org/apache/kafka/storage/internals/log/LogCleaner.java
@@ -464,7 +464,7 @@ public class LogCleaner implements BrokerReconfigurable {
* The cleaner threads do the actual log cleaning. Each thread processes
does its cleaning repeatedly by
* choosing the dirtiest log, cleaning it, and then swapping in the
cleaned segments.
*/
- public class CleanerThread extends ShutdownableThread {
+ public final class CleanerThread extends ShutdownableThread {
private final Logger logger = new
LogContext(logPrefix).logger(CleanerThread.class);
private final Cleaner cleaner;
@@ -472,7 +472,6 @@ public class LogCleaner implements BrokerReconfigurable {
private volatile CleanerStats lastStats = new
CleanerStats(Time.SYSTEM);
private volatile PreCleanStats lastPreCleanStats = new PreCleanStats();
- @SuppressWarnings("this-escape")
public CleanerThread(int threadId) throws NoSuchAlgorithmException {
super("kafka-log-cleaner-thread-" + threadId, false);