This is an automated email from the ASF dual-hosted git repository.

chia7712 pushed a commit to branch 4.1
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/4.1 by this push:
     new 4099f75e559 MINOR: Suppress warning logs for 
UnsupportedVersionException in ClientTelemetryReporter (#20722)
4099f75e559 is described below

commit 4099f75e559f4581302a0de0a26cf0fd4e371eda
Author: Lan Ding <[email protected]>
AuthorDate: Mon Oct 20 17:02:07 2025 +0800

    MINOR: Suppress warning logs for UnsupportedVersionException in 
ClientTelemetryReporter (#20722)
    
    see https://github.com/apache/kafka/pull/20661/files#r2433576874
    Suppress warning logs for `UnsupportedVersionException` in
    `ClientTelemetryReporter`.
    
    Reviewers: Andrew Schofield <[email protected]>
---
 .../common/telemetry/internals/ClientTelemetryReporter.java | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git 
a/clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java
 
b/clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java
index ae60aef66c9..6c80365e2e8 100644
--- 
a/clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java
+++ 
b/clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java
@@ -21,6 +21,7 @@ import org.apache.kafka.common.KafkaException;
 import org.apache.kafka.common.Uuid;
 import org.apache.kafka.common.errors.InterruptException;
 import org.apache.kafka.common.errors.RetriableException;
+import org.apache.kafka.common.errors.UnsupportedVersionException;
 import org.apache.kafka.common.message.GetTelemetrySubscriptionsRequestData;
 import org.apache.kafka.common.message.GetTelemetrySubscriptionsResponseData;
 import org.apache.kafka.common.message.PushTelemetryRequestData;
@@ -527,13 +528,13 @@ public class ClientTelemetryReporter implements 
MetricsReporter {
         @Override
         public void 
handleFailedGetTelemetrySubscriptionsRequest(KafkaException 
maybeFatalException) {
             log.debug("The broker generated an error for the get telemetry 
network API request", maybeFatalException);
-            handleFailedRequest(isRetryable(maybeFatalException));
+            handleFailedRequest(maybeFatalException);
         }
 
         @Override
         public void handleFailedPushTelemetryRequest(KafkaException 
maybeFatalException) {
             log.debug("The broker generated an error for the push telemetry 
network API request", maybeFatalException);
-            handleFailedRequest(isRetryable(maybeFatalException));
+            handleFailedRequest(maybeFatalException);
         }
 
         @Override
@@ -834,7 +835,7 @@ public class ClientTelemetryReporter implements 
MetricsReporter {
             }
         }
 
-        private void handleFailedRequest(boolean shouldWait) {
+        private void handleFailedRequest(KafkaException maybeFatalException) {
             final long nowMs = time.milliseconds();
             lock.writeLock().lock();
             try {
@@ -852,10 +853,12 @@ public class ClientTelemetryReporter implements 
MetricsReporter {
                  again. We may disconnect from the broker and connect to a 
broker that supports client
                  telemetry.
                 */
-                if (shouldWait) {
+                if (isRetryable(maybeFatalException)) {
                     updateErrorResult(DEFAULT_PUSH_INTERVAL_MS, nowMs);
                 } else {
-                    log.warn("Received unrecoverable error from broker, 
disabling telemetry");
+                    if (!(maybeFatalException instanceof 
UnsupportedVersionException)) {
+                        log.warn("Received unrecoverable error from broker, 
disabling telemetry");
+                    }
                     updateErrorResult(Integer.MAX_VALUE, nowMs);
                 }
 

Reply via email to