This is an automated email from the ASF dual-hosted git repository.

chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 114dbfcaa53 KAFKA-20152 Remove unused CoordinatorMetrics#registry 
(#21504)
114dbfcaa53 is described below

commit 114dbfcaa53e48e4b4565b8d81fa608c6c3c6f15
Author: Nick Guo <[email protected]>
AuthorDate: Wed Feb 18 22:10:01 2026 +0800

    KAFKA-20152 Remove unused CoordinatorMetrics#registry (#21504)
    
    These methods are currently unused, and we should remove them.
    
    Reviewers: David Jacot <[email protected]>, Chia-Ping Tsai
     <[email protected]>
---
 .../kafka/coordinator/common/runtime/CoordinatorMetrics.java     | 6 ------
 .../kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java | 5 -----
 .../kafka/coordinator/share/metrics/ShareCoordinatorMetrics.java | 9 ---------
 3 files changed, 20 deletions(-)

diff --git 
a/coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorMetrics.java
 
b/coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorMetrics.java
index 445d873a60f..63e91c389d3 100644
--- 
a/coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorMetrics.java
+++ 
b/coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorMetrics.java
@@ -21,7 +21,6 @@ import org.apache.kafka.server.metrics.KafkaYammerMetrics;
 import org.apache.kafka.timeline.SnapshotRegistry;
 
 import com.yammer.metrics.core.MetricName;
-import com.yammer.metrics.core.MetricsRegistry;
 
 /**
  * CoordinatorMetrics contain all coordinator related metrics. It delegates 
metrics collection to
@@ -52,11 +51,6 @@ public abstract class CoordinatorMetrics {
      */
     public abstract void deactivateMetricsShard(CoordinatorMetricsShard shard);
 
-    /**
-     * @return The metrics registry.
-     */
-    public abstract MetricsRegistry registry();
-
     /**
      * Generate the Yammer MetricName.
      *
diff --git 
a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java
 
b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java
index 9d05727d2e9..4e109c90fd7 100644
--- 
a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java
+++ 
b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java
@@ -422,11 +422,6 @@ public class GroupCoordinatorMetrics extends 
CoordinatorMetrics implements AutoC
         shards.remove(shard.topicPartition());
     }
 
-    @Override
-    public MetricsRegistry registry() {
-        return this.registry;
-    }
-
     @Override
     public void onUpdateLastCommittedOffset(TopicPartition tp, long offset) {
         CoordinatorMetricsShard shard = shards.get(tp);
diff --git 
a/share-coordinator/src/main/java/org/apache/kafka/coordinator/share/metrics/ShareCoordinatorMetrics.java
 
b/share-coordinator/src/main/java/org/apache/kafka/coordinator/share/metrics/ShareCoordinatorMetrics.java
index b24d78def27..4f1e94598d0 100644
--- 
a/share-coordinator/src/main/java/org/apache/kafka/coordinator/share/metrics/ShareCoordinatorMetrics.java
+++ 
b/share-coordinator/src/main/java/org/apache/kafka/coordinator/share/metrics/ShareCoordinatorMetrics.java
@@ -29,8 +29,6 @@ import 
org.apache.kafka.coordinator.common.runtime.CoordinatorMetrics;
 import org.apache.kafka.coordinator.common.runtime.CoordinatorMetricsShard;
 import org.apache.kafka.timeline.SnapshotRegistry;
 
-import com.yammer.metrics.core.MetricsRegistry;
-
 import java.util.Collections;
 import java.util.List;
 import java.util.Map;
@@ -119,13 +117,6 @@ public class ShareCoordinatorMetrics extends 
CoordinatorMetrics implements AutoC
         shards.remove(shard.topicPartition());
     }
 
-    @Override
-    public MetricsRegistry registry() {
-        // we are not using MetricsRegistry in share coordinator
-        // but this method is part for implemented interface
-        return null;
-    }
-
     @Override
     public void onUpdateLastCommittedOffset(TopicPartition tp, long offset) {
         CoordinatorMetricsShard shard = shards.get(tp);

Reply via email to