This is an automated email from the ASF dual-hosted git repository.
schofielaj pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new e1b165bf789 MINOR: Correct default config in test (#21732)
e1b165bf789 is described below
commit e1b165bf7893e93b90bef3cb18bcdd946d709d84
Author: Andrew Schofield <[email protected]>
AuthorDate: Thu Mar 12 15:14:40 2026 +0000
MINOR: Correct default config in test (#21732)
When constructing a Properties for the default configs in
`KafkaApisTest`, the values added should all be strings. In one case, a
boolean was being added. Corrected to a string.
Reviewers: Lianet Magrans <[email protected]>
---
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala | 2 +-
.../main/java/org/apache/kafka/coordinator/group/GroupConfig.java | 2 +-
.../coordinator/group/modern/share/ShareGroupConfigProvider.java | 6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/core/src/test/scala/unit/kafka/server/KafkaApisTest.scala
b/core/src/test/scala/unit/kafka/server/KafkaApisTest.scala
index 6610a4d3247..e5bbc337ac9 100644
--- a/core/src/test/scala/unit/kafka/server/KafkaApisTest.scala
+++ b/core/src/test/scala/unit/kafka/server/KafkaApisTest.scala
@@ -363,7 +363,7 @@ class KafkaApisTest extends Logging {
cgConfigs.put(SHARE_PARTITION_MAX_RECORD_LOCKS_CONFIG,
ShareGroupConfig.SHARE_GROUP_PARTITION_MAX_RECORD_LOCKS_DEFAULT.toString)
cgConfigs.put(SHARE_AUTO_OFFSET_RESET_CONFIG,
GroupConfig.SHARE_AUTO_OFFSET_RESET_DEFAULT)
cgConfigs.put(SHARE_ISOLATION_LEVEL_CONFIG,
GroupConfig.SHARE_ISOLATION_LEVEL_DEFAULT)
- cgConfigs.put(SHARE_RENEW_ACKNOWLEDGE_ENABLE_CONFIG,
GroupConfig.SHARE_RENEW_ACKNOWLEDGE_ENABLE_DEFAULT)
+ cgConfigs.put(SHARE_RENEW_ACKNOWLEDGE_ENABLE_CONFIG,
GroupConfig.SHARE_RENEW_ACKNOWLEDGE_ENABLE_DEFAULT.toString)
cgConfigs.put(STREAMS_HEARTBEAT_INTERVAL_MS_CONFIG,
GroupCoordinatorConfig.STREAMS_GROUP_HEARTBEAT_INTERVAL_MS_DEFAULT.toString)
cgConfigs.put(STREAMS_SESSION_TIMEOUT_MS_CONFIG,
GroupCoordinatorConfig.STREAMS_GROUP_SESSION_TIMEOUT_MS_DEFAULT.toString)
cgConfigs.put(STREAMS_NUM_STANDBY_REPLICAS_CONFIG,
GroupCoordinatorConfig.STREAMS_GROUP_NUM_STANDBY_REPLICAS_DEFAULT.toString)
diff --git
a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java
b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java
index f17ee7fe61d..e0b52574fc3 100644
---
a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java
+++
b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java
@@ -649,7 +649,7 @@ public final class GroupConfig extends AbstractConfig {
throw new IllegalArgumentException("Unknown Share isolation level:
" + shareIsolationLevel);
}
}
-
+
/**
* The share group renew acknowledge enable.
*/
diff --git
a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/share/ShareGroupConfigProvider.java
b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/share/ShareGroupConfigProvider.java
index 532bf6dd2f5..f8d2bd5dc70 100644
---
a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/share/ShareGroupConfigProvider.java
+++
b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/share/ShareGroupConfigProvider.java
@@ -39,9 +39,9 @@ public class ShareGroupConfigProvider {
* @return The record lock duration for the group.
*/
public int recordLockDurationMsOrDefault(String groupId, int defaultValue)
{
- return manager.groupConfig(groupId).
- map(GroupConfig::shareRecordLockDurationMs).
- orElse(defaultValue);
+ return manager.groupConfig(groupId)
+ .map(GroupConfig::shareRecordLockDurationMs)
+ .orElse(defaultValue);
}
/**