This is an automated email from the ASF dual-hosted git repository.
mjsax pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 5b334f644de KAFKA-20193: Remove unused code (#21539)
5b334f644de is described below
commit 5b334f644dee8a6ff5e19bc65745d76ca5988900
Author: Nishant Kumar <[email protected]>
AuthorDate: Sat May 9 04:54:29 2026 +0530
KAFKA-20193: Remove unused code (#21539)
Removes static <T> T value(...) method from
ValueTimestampHeadersDeserializer.
Reviewers: Zheguang Zhao <[email protected]>, Matthias J.
Sax <[email protected]>
---
.../ValueTimestampHeadersDeserializer.java | 10 +---------
.../ValueTimestampHeadersDeserializerTest.java | 23 ----------------------
2 files changed, 1 insertion(+), 32 deletions(-)
diff --git
a/streams/src/main/java/org/apache/kafka/streams/state/internals/ValueTimestampHeadersDeserializer.java
b/streams/src/main/java/org/apache/kafka/streams/state/internals/ValueTimestampHeadersDeserializer.java
index 73f41be794c..2f6213b58b8 100644
---
a/streams/src/main/java/org/apache/kafka/streams/state/internals/ValueTimestampHeadersDeserializer.java
+++
b/streams/src/main/java/org/apache/kafka/streams/state/internals/ValueTimestampHeadersDeserializer.java
@@ -95,13 +95,5 @@ class ValueTimestampHeadersDeserializer<V> implements
WrappingNullableDeserializ
initNullableDeserializer(valueDeserializer, getter);
}
- /**
- * Extract value from serialized ValueTimestampHeaders.
- */
- static <T> T value(final byte[] rawValueTimestampHeaders, final
Deserializer<T> deserializer) {
- if (rawValueTimestampHeaders == null) {
- return null;
- }
- return deserializer.deserialize("",
Utils.rawPlainValue(rawValueTimestampHeaders));
- }
+
}
diff --git
a/streams/src/test/java/org/apache/kafka/streams/state/internals/ValueTimestampHeadersDeserializerTest.java
b/streams/src/test/java/org/apache/kafka/streams/state/internals/ValueTimestampHeadersDeserializerTest.java
index 4755eb3257c..56386b8fa5e 100644
---
a/streams/src/test/java/org/apache/kafka/streams/state/internals/ValueTimestampHeadersDeserializerTest.java
+++
b/streams/src/test/java/org/apache/kafka/streams/state/internals/ValueTimestampHeadersDeserializerTest.java
@@ -21,7 +21,6 @@ import org.apache.kafka.common.header.Header;
import org.apache.kafka.common.header.Headers;
import org.apache.kafka.common.header.internals.RecordHeaders;
import org.apache.kafka.common.serialization.Deserializer;
-import org.apache.kafka.common.serialization.Serde;
import org.apache.kafka.common.serialization.Serdes;
import org.apache.kafka.streams.state.ValueTimestampHeaders;
@@ -184,28 +183,6 @@ public class ValueTimestampHeadersDeserializerTest {
assertNull(header.value());
}
- @Test
- public void shouldExtractValue() {
- final Headers headers = new RecordHeaders()
- .add("key1", "value1".getBytes());
- final ValueTimestampHeaders<String> original =
- ValueTimestampHeaders.make("test-value", 123456789L, headers);
-
- final byte[] serialized = serializer.serialize(TOPIC, original);
-
- try (final Serde<String> stringSerde = Serdes.String()) {
- final String value =
ValueTimestampHeadersDeserializer.value(serialized, stringSerde.deserializer());
- assertNotNull(value);
- assertEquals("test-value", value);
- }
- }
-
- @Test
- public void shouldReturnNullForRawValueWhenInputIsNull() {
- final ValueTimestampHeaders<String> value =
ValueTimestampHeadersDeserializer.value(null, deserializer);
- assertNull(value);
- }
-
@ParameterizedTest
@MethodSource("headers")
public void shouldExtractTimestamp(final Headers headers) {