This is an automated email from the ASF dual-hosted git repository.
chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 5d86a6b8244 MINOR: Remove unnecessary null check in
DefaultStatePersister#stop (#22308)
5d86a6b8244 is described below
commit 5d86a6b8244f92c61cc8d2c57a3cbb981962c5a4
Author: KC.H <[email protected]>
AuthorDate: Thu May 21 17:14:36 2026 +0800
MINOR: Remove unnecessary null check in DefaultStatePersister#stop (#22308)
The `stateManager` field is `final` and assigned in both constructors of
`DefaultStatePersister`, so the `if (stateManager != null)` guard in
`stop()` can never evaluate to false.
No behavior change; existing tests in `DefaultStatePersisterTest`
remain sufficient.
Reviewers: Ken Huang <[email protected]>, Chia-Ping Tsai
<[email protected]>
---
.../apache/kafka/server/share/persister/DefaultStatePersister.java | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git
a/server-common/src/main/java/org/apache/kafka/server/share/persister/DefaultStatePersister.java
b/server-common/src/main/java/org/apache/kafka/server/share/persister/DefaultStatePersister.java
index 7522b0e0f0f..7e1a6d7d148 100644
---
a/server-common/src/main/java/org/apache/kafka/server/share/persister/DefaultStatePersister.java
+++
b/server-common/src/main/java/org/apache/kafka/server/share/persister/DefaultStatePersister.java
@@ -69,9 +69,7 @@ public class DefaultStatePersister implements Persister {
@Override
public void stop() {
try {
- if (stateManager != null) {
- stateManager.stop();
- }
+ stateManager.stop();
} catch (Exception e) {
log.error("Unable to stop state manager", e);
}
