This is an automated email from the ASF dual-hosted git repository.
chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 6112e3ff1eb MINOR: Correct the variable name in remote storage's test
(#22349)
6112e3ff1eb is described below
commit 6112e3ff1eb327f3a31672bc901bf4f045ab979d
Author: Jian <[email protected]>
AuthorDate: Sat May 23 10:32:26 2026 +0800
MINOR: Correct the variable name in remote storage's test (#22349)
This is a follow-up PR for
https://github.com/apache/kafka/pull/20913#discussion_r3286497277
Thanks. cc @kamalcph
Reviewers: Murali Basani <[email protected]>, Ken Huang
<[email protected]>, Chia-Ping Tsai <[email protected]>
---
.../kafka/server/DynamicBrokerConfigTest.scala | 34 +++++++++++-----------
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git
a/core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala
b/core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala
index 581af682793..a451847994e 100755
--- a/core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala
+++ b/core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala
@@ -771,35 +771,35 @@ class DynamicBrokerConfigTest {
}
@Test
- def testDynamicRemoteCopyLagThrowsOnIncorrectConfig(): Unit = {
- // remote copy lag ms cannot exceed effective local retention ms
- verifyIncorrectRemoteCopyLagProps(
+ def testDynamicLogRemoteCopyLagThrowsOnIncorrectConfig(): Unit = {
+ // log remote copy lag ms cannot exceed effective log local retention ms
+ verifyIncorrectLogRemoteCopyLagProps(
retentionMs = 1000L,
logLocalRetentionMs = -2L,
- remoteCopyLagMs = 1001L,
+ logRemoteCopyLagMs = 1001L,
retentionBytes = 1000L,
logLocalRetentionBytes = -2L,
- remoteCopyLagBytes = 100L
+ logRemoteCopyLagBytes = 100L
)
- // remote copy lag bytes cannot exceed effective local retention bytes
- verifyIncorrectRemoteCopyLagProps(
+ // log remote copy lag bytes cannot exceed effective log local retention
bytes
+ verifyIncorrectLogRemoteCopyLagProps(
retentionMs = 1000L,
logLocalRetentionMs = -2L,
- remoteCopyLagMs = 100L,
+ logRemoteCopyLagMs = 100L,
retentionBytes = 1000L,
logLocalRetentionBytes = -2L,
- remoteCopyLagBytes = 1001L
+ logRemoteCopyLagBytes = 1001L
)
}
- def verifyIncorrectRemoteCopyLagProps(retentionMs: Long,
- logLocalRetentionMs: Long,
- remoteCopyLagMs: Long,
- retentionBytes: Long,
- logLocalRetentionBytes: Long,
- remoteCopyLagBytes: Long): Unit = {
+ def verifyIncorrectLogRemoteCopyLagProps(retentionMs: Long,
+ logLocalRetentionMs: Long,
+ logRemoteCopyLagMs: Long,
+ retentionBytes: Long,
+ logLocalRetentionBytes: Long,
+ logRemoteCopyLagBytes: Long): Unit
= {
val props = TestUtils.createBrokerConfig(0, port = 8181)
props.put(ServerLogConfigs.LOG_RETENTION_TIME_MILLIS_CONFIG,
retentionMs.toString)
props.put(ServerLogConfigs.LOG_RETENTION_BYTES_CONFIG,
retentionBytes.toString)
@@ -810,9 +810,9 @@ class DynamicBrokerConfigTest {
val newProps = new Properties()
newProps.put(RemoteLogManagerConfig.LOG_LOCAL_RETENTION_MS_PROP,
logLocalRetentionMs.toString)
- newProps.put(RemoteLogManagerConfig.LOG_REMOTE_COPY_LAG_MS_PROP,
remoteCopyLagMs.toString)
+ newProps.put(RemoteLogManagerConfig.LOG_REMOTE_COPY_LAG_MS_PROP,
logRemoteCopyLagMs.toString)
newProps.put(RemoteLogManagerConfig.LOG_LOCAL_RETENTION_BYTES_PROP,
logLocalRetentionBytes.toString)
- newProps.put(RemoteLogManagerConfig.LOG_REMOTE_COPY_LAG_BYTES_PROP,
remoteCopyLagBytes.toString)
+ newProps.put(RemoteLogManagerConfig.LOG_REMOTE_COPY_LAG_BYTES_PROP,
logRemoteCopyLagBytes.toString)
// validate default config
assertThrows(classOf[ConfigException], () =>
config.dynamicConfig.validate(newProps, perBrokerConfig = false))
// validate per broker config
