This is an automated email from the ASF dual-hosted git repository.
apoorvmittal10 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 9ff2c5b1c26 MINOR: Remove redundant start calls from persister and dlq
mgr. (#22446)
9ff2c5b1c26 is described below
commit 9ff2c5b1c266fdc83eca2853363c3914bce6f140
Author: Sushant Mahajan <[email protected]>
AuthorDate: Tue Jun 2 14:30:54 2026 +0530
MINOR: Remove redundant start calls from persister and dlq mgr. (#22446)
* The `start` method in both `PersisterStateManager` and
`ShareGroupDLQStateManager` currently makes redundant call to set
`isStarted` atomic boolean despite being already done in the
`compareAndSet` method. Hence, removing those.
Reviewers: Apoorv Mittal <[email protected]>
---
.../org/apache/kafka/server/share/persister/PersisterStateManager.java | 1 -
.../org/apache/kafka/server/share/dlq/ShareGroupDLQStateManager.java | 1 -
2 files changed, 2 deletions(-)
diff --git
a/server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java
b/server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java
index 00e2b645235..9fca67856af 100644
---
a/server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java
+++
b/server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java
@@ -165,7 +165,6 @@ public class PersisterStateManager {
public void start() {
if (isStarted.compareAndSet(false, true)) {
this.sender.start();
- isStarted.set(true);
}
}
diff --git
a/server/src/main/java/org/apache/kafka/server/share/dlq/ShareGroupDLQStateManager.java
b/server/src/main/java/org/apache/kafka/server/share/dlq/ShareGroupDLQStateManager.java
index 90f880ee08d..8613582ceea 100644
---
a/server/src/main/java/org/apache/kafka/server/share/dlq/ShareGroupDLQStateManager.java
+++
b/server/src/main/java/org/apache/kafka/server/share/dlq/ShareGroupDLQStateManager.java
@@ -125,7 +125,6 @@ public class ShareGroupDLQStateManager {
if (isStarted.compareAndSet(false, true)) {
log.info("Starting ShareGroupDLQStateManager");
this.sender.start();
- isStarted.set(true);
}
}