(kafka) branch trunk updated: MINOR: avoid redundant HashMap lookups and simplify Uuid conversions (#22122)

[mimaison]

This is an automated email from the ASF dual-hosted git repository.

mimaison pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 2ad4c7a2ef1 MINOR: avoid redundant HashMap lookups and simplify Uuid 
conversions (#22122)
2ad4c7a2ef1 is described below

commit 2ad4c7a2ef1d3f36c37ec3d848062f61ee0232fe
Author: Mirko Alicastro <mirkoalicas...@gmail.com>
AuthorDate: Sat Jun 20 13:21:12 2026 +0200

    MINOR: avoid redundant HashMap lookups and simplify Uuid conversions 
(#22122)
    
    
    Reviewers: Mickael Maison <mickael.mai...@gmail.com>, Uladzislau Blok 
<blok...@gmail.com>, Sushant Mahajan <sushant.mahaja...@gmail.com>
---
 clients/src/main/java/org/apache/kafka/common/Uuid.java   | 10 ++--------
 .../kafka/coordinator/group/GroupMetadataManager.java     | 15 ++++++++-------
 2 files changed, 10 insertions(+), 15 deletions(-)

diff --git a/clients/src/main/java/org/apache/kafka/common/Uuid.java 
b/clients/src/main/java/org/apache/kafka/common/Uuid.java
index 5463f7e4a7f..31478f6fed3 100644
--- a/clients/src/main/java/org/apache/kafka/common/Uuid.java
+++ b/clients/src/main/java/org/apache/kafka/common/Uuid.java
@@ -174,11 +174,7 @@ public class Uuid implements Comparable<Uuid> {
      */
     public static Uuid[] toArray(List<Uuid> list) {
         if (list == null) return null;
-        Uuid[] array = new Uuid[list.size()];
-        for (int i = 0; i < list.size(); i++) {
-            array[i] = list.get(i);
-        }
-        return array;
+        return list.toArray(new Uuid[0]);
     }
 
     /**
@@ -189,8 +185,6 @@ public class Uuid implements Comparable<Uuid> {
      */
     public static List<Uuid> toList(Uuid[] array) {
         if (array == null) return null;
-        List<Uuid> list = new ArrayList<>(array.length);
-        list.addAll(Arrays.asList(array));
-        return list;
+        return new ArrayList<>(Arrays.asList(array));
     }
 }
diff --git 
a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java
 
b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java
index ef62f63eca1..4f7e10ae07e 100644
--- 
a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java
+++ 
b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java
@@ -3178,15 +3178,16 @@ public class GroupMetadataManager {
         combinedTopicIdSet.addAll(initializingSet);
 
         for (Uuid topicId : combinedTopicIdSet) {
-            Set<Integer> initializedPartitions = 
initialized.containsKey(topicId) ? initialized.get(topicId).partitions() : new 
HashSet<>();
-            long timestamp = initialized.containsKey(topicId) ? 
initialized.get(topicId).timestamp() : -1;
-            String name = initialized.containsKey(topicId) ? 
initialized.get(topicId).name() : "UNKNOWN";
+            InitMapValue initializedValue = initialized.get(topicId);
+            Set<Integer> finalPartitions = initializedValue != null ? new 
HashSet<>(initializedValue.partitions()) : new HashSet<>();
+            long timestamp = initializedValue != null ? 
initializedValue.timestamp() : -1;
+            String name = initializedValue != null ? initializedValue.name() : 
"UNKNOWN";
 
-            Set<Integer> finalPartitions = new 
HashSet<>(initializedPartitions);
             if (initializingSet.contains(topicId)) {
-                finalPartitions.addAll(initializing.get(topicId).partitions());
-                timestamp = initializing.get(topicId).timestamp();
-                name = initializing.get(topicId).name();
+                InitMapValue initializingValue = initializing.get(topicId);
+                finalPartitions.addAll(initializingValue.partitions());
+                timestamp = initializingValue.timestamp();
+                name = initializingValue.name();
             }
             finalInitMap.putIfAbsent(topicId, new InitMapValue(name, 
finalPartitions, timestamp));
         }