(kafka) branch trunk updated: MINOR: Fix assertion and grammar issues in KafkaConsumerTest (#22613)

[chia7712]

This is an automated email from the ASF dual-hosted git repository.

chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 1a46339e90b MINOR: Fix assertion and grammar issues in 
KafkaConsumerTest (#22613)
1a46339e90b is described below

commit 1a46339e90ba28e5f5291dee86e9984f9d177068
Author: Park Jiwon <57484954+david-pa...@users.noreply.github.com>
AuthorDate: Sun Jun 21 22:12:50 2026 +0900

    MINOR: Fix assertion and grammar issues in KafkaConsumerTest (#22613)
    
    - Fix grammar error in KafkConsumerTest
    - `"production ready!"` → `"production-ready!"` to match actual log
    message
    - Use `invalidRecordOffset - 1` instead of `invalidRecordNumber - 2` in
    lastOffset assertion for semantic clarity
    
    Reviewers: Chia-Ping Tsai <chia7...@gmail.com>
---
 .../java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java
 
b/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java
index 0d4fc11dc7c..2104ff42b7b 100644
--- 
a/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java
+++ 
b/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java
@@ -368,7 +368,7 @@ public class KafkaConsumerTest {
 
     @ParameterizedTest
     @EnumSource(GroupProtocol.class)
-    public void 
testUnSubscribingNonExisingMetricsDoesntCauseError(GroupProtocol groupProtocol) 
{
+    public void 
testUnsubscribingNonExistingMetricsDoesntCauseError(GroupProtocol 
groupProtocol) {
         Properties props = new Properties();
         props.setProperty(ConsumerConfig.GROUP_PROTOCOL_CONFIG, 
groupProtocol.name());
         props.setProperty(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, 
"localhost:9999");
@@ -518,7 +518,7 @@ public class KafkaConsumerTest {
         assertEquals(Set.of(tp0), records.partitions());
         assertEquals(invalidRecordNumber - 1, records.records(tp0).size());
         long lastOffset = records.records(tp0).get(records.records(tp0).size() 
- 1).offset();
-        assertEquals(invalidRecordNumber - 2, lastOffset);
+        assertEquals(invalidRecordOffset - 1, lastOffset);
         assertEquals(1, records.nextOffsets().size());
         assertEquals(new OffsetAndMetadata(lastOffset + 1), 
records.nextOffsets().get(tp0));
 
@@ -680,7 +680,7 @@ public class KafkaConsumerTest {
             appender.setClassLogger(ClassicKafkaConsumer.class, Level.INFO);
             consumer = newConsumer(props, new StringDeserializer(), new 
StringDeserializer());
             assertFalse(
-                    appender.getMessages().stream().anyMatch(m -> 
m.contains("The consumer rebalance protocol (KIP-848) is production ready!")),
+                    appender.getMessages().stream().anyMatch(m -> 
m.contains("The consumer rebalance protocol (KIP-848) is production-ready!")),
                     "Should not log recommendation when no group.id is set"
             );
         }