This is an automated email from the ASF dual-hosted git repository.
chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new d96cca2eb50 KAFKA-20377 Add to pass additional Docker build arguments
in the system tests (#22578)
d96cca2eb50 is described below
commit d96cca2eb508baa57db198d674b57b6b8684389e
Author: Maros Orsak <[email protected]>
AuthorDate: Wed Jun 24 20:41:54 2026 +0200
KAFKA-20377 Add to pass additional Docker build arguments in the system
tests (#22578)
Currently, passing additional Docker build arguments to ducker-ak
requires using sed to rewrite the script at runtime i.e.,:
```bash
${SED} -i "s|\${docker_args}|${ADDITIONAL_BUILD_ARGS}|"
tests/docker/ducker-ak
```
This is fragile (any rename in ducker-ak silently breaks it), mutates a
checked-in source file during CI, and requires a hardcoded list of
supported args that must be updated for every new build arg.
This PR adds native` --build-arg` support to ducker-ak, following the
same CLI > ENV > default pattern established by --memory (KAFKA-20378)
and --skip-build (KAFKA-20379). The same CI workflow becomes:
```bash
DOCKER_BUILD_ARGS="--build-arg BASE_IMAGE=base-image --build-arg
PYTHON_VERSION=3.11 --build-arg ANOTHER_ARG_NAME=another-arg-name"
./tests/docker/run_tests.sh
// or via ducker-ak up
./tests/docker/ducker-ak up --build-arg BASE_IMAGE=base-image
--build-arg PYTHON_VERSION=3.11 ...
```
Reviewers: Chia-Ping Tsai <[email protected]>, Luke Chen
<[email protected]>
---
tests/docker/ducker-ak | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/tests/docker/ducker-ak b/tests/docker/ducker-ak
index 1d9a8b2fcd6..0892e4c1aa9 100755
--- a/tests/docker/ducker-ak
+++ b/tests/docker/ducker-ak
@@ -79,7 +79,7 @@ help|-h|--help
up [-n|--num-nodes NUM_NODES] [-f|--force] [-c|--clean-build] [docker-image]
[-C|--custom-ducktape DIR] [-e|--expose-ports ports] [-j|--jdk
JDK_VERSION] [--ipv6]
- [--memory MEMORY_LIMIT]
+ [--memory MEMORY_LIMIT] [--build-arg KEY=VALUE]
Bring up a cluster with the specified amount of nodes (defaults to
${default_num_nodes}).
The docker image name defaults to ${default_image_name}. If --force is
specified, we will
attempt to bring up an image even some parameters are not valid.
@@ -106,6 +106,12 @@ up [-n|--num-nodes NUM_NODES] [-f|--force]
[-c|--clean-build] [docker-image]
forced during prepare_native_dir, even if the tarball already exists. Can
also be triggered via
the CLEAN_BUILD environment variable (e.g., CLEAN_BUILD=true).
+ If --build-arg is specified, the given KEY=VALUE pair is passed as a
Docker build argument
+ to the image build. This flag can be repeated to pass multiple build
arguments. Can also be
+ set via the DOCKER_BUILD_ARGS environment variable (e.g.,
+ DOCKER_BUILD_ARGS="--build-arg KEY1=VAL1 --build-arg KEY2=VAL2"). The
--build-arg flag
+ takes precedence over the environment variable.
+
Note that port 5678 will be automatically exposed for ducker01 node and
will be mapped to 5678
on your local machine to enable debugging in VS Code.
@@ -417,10 +423,12 @@ ducker_up() {
-c|--clean-build) set_once clean_build "true" "clean build";
shift;;
-m|--kafka_mode) set_once kafka_mode "${2}" "the mode in which
kafka will run"; shift 2;;
--memory) set_once docker_run_memory_limit "${2}" "the container
memory limit"; shift 2;;
+ --build-arg) verify_command_line_argument "${2}" "docker build
arg"; docker_args="${docker_args} --build-arg ${2}"; shift 2;;
--ipv6) set_once ipv6 "true" "enable IPv6"; shift;;
*) set_once image_name "${1}" "container image name"; shift;;
esac
done
+ [[ -n "${docker_args}" ]] || docker_args="${DOCKER_BUILD_ARGS:-}"
[[ -n "${clean_build}" ]] || clean_build="${CLEAN_BUILD:-}"
[[ -n "${num_nodes}" ]] || num_nodes="${default_num_nodes}"
[[ -n "${jdk_version}" ]] || jdk_version="${default_jdk}"
