This is an automated email from the ASF dual-hosted git repository.
AndrewJSchofield pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 19815b82ce6 KAFKA-20410: Make KIP-1191 cluster configs dynamic.
(#22949)
19815b82ce6 is described below
commit 19815b82ce6b9281c1f42ef964aa226800809d90
Author: Sushant Mahajan <[email protected]>
AuthorDate: Mon Jul 27 12:51:56 2026 +0530
KAFKA-20410: Make KIP-1191 cluster configs dynamic. (#22949)
KIP-1191 defines share group DLQ configs
`errors.deadletterqueue.auto.create.topics.enable` and
`errors.deadletterqueue.topic.name.prefix` as DYNAMIC cluster configs,
which wasn't the case in the code base. This PR remedies the situation.
Reviewers: Andrew Schofield <[email protected]>
---
.../kafka/coordinator/group/GroupCoordinatorConfig.java | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git
a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java
b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java
index 14646c197a5..35ec327c31e 100644
---
a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java
+++
b/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java
@@ -424,6 +424,8 @@ public class GroupCoordinatorConfig {
CONSUMER_GROUP_ASSIGNOR_OFFLOAD_ENABLE_CONFIG,
SHARE_GROUP_ASSIGNMENT_INTERVAL_MS_CONFIG,
SHARE_GROUP_ASSIGNOR_OFFLOAD_ENABLE_CONFIG,
+ ERRORS_DEADLETTERQUEUE_AUTO_CREATE_TOPICS_ENABLE_CONFIG,
+ ERRORS_DEADLETTERQUEUE_TOPIC_NAME_PREFIX_CONFIG,
STREAMS_GROUP_ASSIGNMENT_INTERVAL_MS_CONFIG,
STREAMS_GROUP_ASSIGNOR_OFFLOAD_ENABLE_CONFIG
);
@@ -561,9 +563,6 @@ public class GroupCoordinatorConfig {
private final int shareGroupMinAssignmentIntervalMs;
private final int shareGroupMaxAssignmentIntervalMs;
private final int shareGroupInitializeRetryIntervalMs;
- // DLQ configurations
- private final boolean errorsDLQAutoCreateTopicsEnable;
- private final String errorsDLQTopicNamePrefix;
// Streams group configurations
private final int streamsGroupSessionTimeoutMs;
private final int streamsGroupMinSessionTimeoutMs;
@@ -632,9 +631,6 @@ public class GroupCoordinatorConfig {
this.shareGroupMinAssignmentIntervalMs =
config.getInt(GroupCoordinatorConfig.SHARE_GROUP_MIN_ASSIGNMENT_INTERVAL_MS_CONFIG);
this.shareGroupMaxAssignmentIntervalMs =
config.getInt(GroupCoordinatorConfig.SHARE_GROUP_MAX_ASSIGNMENT_INTERVAL_MS_CONFIG);
this.shareGroupInitializeRetryIntervalMs = Math.max(initializeRetryMs,
this.offsetCommitTimeoutMs);
- // DLQ configurations
- this.errorsDLQAutoCreateTopicsEnable =
config.getBoolean(GroupCoordinatorConfig.ERRORS_DEADLETTERQUEUE_AUTO_CREATE_TOPICS_ENABLE_CONFIG);
- this.errorsDLQTopicNamePrefix =
config.getString(GroupCoordinatorConfig.ERRORS_DEADLETTERQUEUE_TOPIC_NAME_PREFIX_CONFIG);
// Streams group configurations
this.streamsGroupSessionTimeoutMs =
config.getInt(GroupCoordinatorConfig.STREAMS_GROUP_SESSION_TIMEOUT_MS_CONFIG);
this.streamsGroupMinSessionTimeoutMs =
config.getInt(GroupCoordinatorConfig.STREAMS_GROUP_MIN_SESSION_TIMEOUT_MS_CONFIG);
@@ -1298,14 +1294,14 @@ public class GroupCoordinatorConfig {
* Whether automatic creation of DLQ topics is enabled.
*/
public boolean errorsDLQAutoCreateTopicsEnable() {
- return errorsDLQAutoCreateTopicsEnable;
+ return
config.getBoolean(GroupCoordinatorConfig.ERRORS_DEADLETTERQUEUE_AUTO_CREATE_TOPICS_ENABLE_CONFIG);
}
/**
* The required prefix for DLQ topic names.
*/
public String errorsDLQTopicNamePrefix() {
- return errorsDLQTopicNamePrefix;
+ return
config.getString(GroupCoordinatorConfig.ERRORS_DEADLETTERQUEUE_TOPIC_NAME_PREFIX_CONFIG);
}
/**
