(kafka) branch trunk updated: MINOR: Clean up LogConfig defaults and unused helper (#22932)

[chia7712]

This is an automated email from the ASF dual-hosted git repository.

chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 8e8e90aaf3a MINOR: Clean up LogConfig defaults and unused helper 
(#22932)
8e8e90aaf3a is described below

commit 8e8e90aaf3aeff1cc74c2b1b50d1c3b7f4070310
Author: Parker Chang <parkerhiphop...@gmail.com>
AuthorDate: Sun Aug 2 03:11:14 2026 +0800

    MINOR: Clean up LogConfig defaults and unused helper (#22932)
    
    Remove the unused LogConfigDef#serverConfigName helper.
    
    Also use the named default constants for remote.log.copy.disable and
    remote.log.delete.on.disable topic config definitions instead of literal
    false values.
    
    Reviewers: Chia-Ping Tsai <chia7...@gmail.com>, Ken Huang
     <s7133...@gmail.com>
---
 .../org/apache/kafka/storage/internals/log/LogConfig.java  | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git 
a/storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java 
b/storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java
index 10da86e05fb..f4a1865f26d 100644
--- 
a/storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java
+++ 
b/storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java
@@ -121,9 +121,6 @@ public class LogConfig extends AbstractConfig {
                 return super.getConfigValue(key, headerName);
         }
 
-        public Optional<String> serverConfigName(String configName) {
-            return 
Optional.ofNullable(ServerTopicConfigSynonyms.TOPIC_CONFIG_SYNONYMS.get(configName));
-        }
     }
 
     // Visible for testing
@@ -139,10 +136,11 @@ public class LogConfig extends AbstractConfig {
     public static final double DEFAULT_MIN_CLEANABLE_DIRTY_RATIO = 0.5;
     public static final boolean DEFAULT_UNCLEAN_LEADER_ELECTION_ENABLE = false;
     public static final boolean DEFAULT_PREALLOCATE = false;
+    public static final boolean DEFAULT_ERRORS_DEADLETTERQUEUE_GROUP_ENABLE = 
false;
 
     public static final boolean DEFAULT_REMOTE_STORAGE_ENABLE = false;
-    public static final boolean DEFAULT_REMOTE_LOG_COPY_DISABLE_CONFIG = false;
-    public static final boolean DEFAULT_REMOTE_LOG_DELETE_ON_DISABLE_CONFIG = 
false;
+    public static final boolean DEFAULT_REMOTE_LOG_COPY_DISABLE = false;
+    public static final boolean DEFAULT_REMOTE_LOG_DELETE_ON_DISABLE = false;
     public static final long DEFAULT_LOCAL_RETENTION_BYTES = -2; // It 
indicates the value to be derived from RetentionBytes
     public static final long DEFAULT_LOCAL_RETENTION_MS = -2; // It indicates 
the value to be derived from RetentionMs
 
@@ -253,11 +251,11 @@ public class LogConfig extends AbstractConfig {
                         TopicConfig.LOCAL_LOG_RETENTION_MS_DOC)
                 .define(TopicConfig.LOCAL_LOG_RETENTION_BYTES_CONFIG, LONG, 
DEFAULT_LOCAL_RETENTION_BYTES, atLeast(-2), MEDIUM,
                         TopicConfig.LOCAL_LOG_RETENTION_BYTES_DOC)
-                .define(TopicConfig.REMOTE_LOG_COPY_DISABLE_CONFIG, BOOLEAN, 
false, MEDIUM, TopicConfig.REMOTE_LOG_COPY_DISABLE_DOC)
+                .define(TopicConfig.REMOTE_LOG_COPY_DISABLE_CONFIG, BOOLEAN, 
DEFAULT_REMOTE_LOG_COPY_DISABLE, MEDIUM, 
TopicConfig.REMOTE_LOG_COPY_DISABLE_DOC)
                 .define(TopicConfig.REMOTE_COPY_LAG_MS_CONFIG, LONG, 
RemoteLogManagerConfig.DEFAULT_LOG_REMOTE_COPY_LAG_MS, 
atLeast(RemoteLogManagerConfig.MAX_LOG_REMOTE_COPY_LAG_MS), MEDIUM, 
TopicConfig.REMOTE_COPY_LAG_MS_DOC)
                 .define(TopicConfig.REMOTE_COPY_LAG_BYTES_CONFIG, LONG, 
RemoteLogManagerConfig.DEFAULT_LOG_REMOTE_COPY_LAG_BYTES, 
atLeast(RemoteLogManagerConfig.MAX_LOG_REMOTE_COPY_LAG_BYTES), MEDIUM, 
TopicConfig.REMOTE_COPY_LAG_BYTES_DOC)
-                .define(TopicConfig.REMOTE_LOG_DELETE_ON_DISABLE_CONFIG, 
BOOLEAN, false, MEDIUM, TopicConfig.REMOTE_LOG_DELETE_ON_DISABLE_DOC)
-                
.define(TopicConfig.ERRORS_DEADLETTERQUEUE_GROUP_ENABLE_CONFIG, BOOLEAN, false, 
MEDIUM, TopicConfig.ERRORS_DEADLETTERQUEUE_GROUP_ENABLE_DOC)
+                .define(TopicConfig.REMOTE_LOG_DELETE_ON_DISABLE_CONFIG, 
BOOLEAN, DEFAULT_REMOTE_LOG_DELETE_ON_DISABLE, MEDIUM, 
TopicConfig.REMOTE_LOG_DELETE_ON_DISABLE_DOC)
+                
.define(TopicConfig.ERRORS_DEADLETTERQUEUE_GROUP_ENABLE_CONFIG, BOOLEAN, 
DEFAULT_ERRORS_DEADLETTERQUEUE_GROUP_ENABLE, MEDIUM, 
TopicConfig.ERRORS_DEADLETTERQUEUE_GROUP_ENABLE_DOC)
                 .defineInternal(INTERNAL_SEGMENT_BYTES_CONFIG, INT, null, 
null, MEDIUM, INTERNAL_SEGMENT_BYTES_DOC);
     }