Repository: karaf Updated Branches: refs/heads/master 084f579bd -> 5ae687195
[KARAF-2913]JAAS JDBCBackingEngine has the wrong condition to iterate results, no users are returned Project: http://git-wip-us.apache.org/repos/asf/karaf/repo Commit: http://git-wip-us.apache.org/repos/asf/karaf/commit/5ae68719 Tree: http://git-wip-us.apache.org/repos/asf/karaf/tree/5ae68719 Diff: http://git-wip-us.apache.org/repos/asf/karaf/diff/5ae68719 Branch: refs/heads/master Commit: 5ae68719554dd13d72598ad18cef533518ab9cf4 Parents: 084f579 Author: Freeman Fang <[email protected]> Authored: Wed Apr 16 09:16:47 2014 +0800 Committer: Freeman Fang <[email protected]> Committed: Wed Apr 16 09:16:47 2014 +0800 ---------------------------------------------------------------------- .../org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngine.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/karaf/blob/5ae68719/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngine.java ---------------------------------------------------------------------- diff --git a/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngine.java b/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngine.java index 4bb15cf..9723de8 100644 --- a/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngine.java +++ b/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngine.java @@ -192,7 +192,7 @@ public class JDBCBackingEngine implements BackingEngine { //Remove from users listUserStatement = connection.prepareStatement(selectUsersQuery); usersResultSet = listUserStatement.executeQuery(); - while (!usersResultSet.next()) { + while (usersResultSet.next()) { String username = usersResultSet.getString("USERNAME"); users.add(new UserPrincipal(username)); } @@ -242,7 +242,7 @@ public class JDBCBackingEngine implements BackingEngine { rolesResultSet = listRolesStatement.executeQuery(); - while (!rolesResultSet.next()) { + while (rolesResultSet.next()) { String role = rolesResultSet.getString(1); roles.add(new RolePrincipal(role)); }
