Repository: karaf Updated Branches: refs/heads/karaf-2.3.x 4ea848923 -> 5ee43c11a
[KARAF-2913]JAAS JDBCBackingEngine has the wrong condition to iterate results, no users are returned (cherry picked from commit 5ae68719554dd13d72598ad18cef533518ab9cf4) Project: http://git-wip-us.apache.org/repos/asf/karaf/repo Commit: http://git-wip-us.apache.org/repos/asf/karaf/commit/5ee43c11 Tree: http://git-wip-us.apache.org/repos/asf/karaf/tree/5ee43c11 Diff: http://git-wip-us.apache.org/repos/asf/karaf/diff/5ee43c11 Branch: refs/heads/karaf-2.3.x Commit: 5ee43c11a1f8771b3295da3e6bfe45b6ea5a6e05 Parents: 4ea8489 Author: Freeman Fang <[email protected]> Authored: Wed Apr 16 09:16:47 2014 +0800 Committer: Freeman Fang <[email protected]> Committed: Wed Apr 16 09:18:58 2014 +0800 ---------------------------------------------------------------------- .../org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngine.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/karaf/blob/5ee43c11/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngine.java ---------------------------------------------------------------------- diff --git a/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngine.java b/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngine.java index 4f93e11..ae61237 100644 --- a/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngine.java +++ b/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngine.java @@ -189,7 +189,7 @@ public class JDBCBackingEngine implements BackingEngine { //Remove from users listUserStatement = connection.prepareStatement(selectUsersQuery); usersResultSet = listUserStatement.executeQuery(); - while (!usersResultSet.next()) { + while (usersResultSet.next()) { String username = usersResultSet.getString("USERNAME"); users.add(new UserPrincipal(username)); } @@ -239,7 +239,7 @@ public class JDBCBackingEngine implements BackingEngine { rolesResultSet = listRolesStatement.executeQuery(); - while (!rolesResultSet.next()) { + while (rolesResultSet.next()) { String role = rolesResultSet.getString(1); roles.add(new RolePrincipal(role)); }
