Repository: karaf Updated Branches: refs/heads/karaf-2.x 0d604d4a8 -> 9da61ba12
Add a warn message if the heap dump can't be created Project: http://git-wip-us.apache.org/repos/asf/karaf/repo Commit: http://git-wip-us.apache.org/repos/asf/karaf/commit/9da61ba1 Tree: http://git-wip-us.apache.org/repos/asf/karaf/tree/9da61ba1 Diff: http://git-wip-us.apache.org/repos/asf/karaf/diff/9da61ba1 Branch: refs/heads/karaf-2.x Commit: 9da61ba12f919422baca5a9458b592d20557ede2 Parents: 0d604d4 Author: Jean-Baptiste Onofré <[email protected]> Authored: Fri Aug 22 14:51:43 2014 +0200 Committer: Jean-Baptiste Onofré <[email protected]> Committed: Fri Aug 22 14:51:43 2014 +0200 ---------------------------------------------------------------------- .../src/main/resources/OSGI-INF/blueprint/shell-diagnostic.xml | 1 - .../org/apache/karaf/diagnostic/common/HeapDumpProvider.java | 6 +++++- 2 files changed, 5 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/karaf/blob/9da61ba1/diagnostic/command/src/main/resources/OSGI-INF/blueprint/shell-diagnostic.xml ---------------------------------------------------------------------- diff --git a/diagnostic/command/src/main/resources/OSGI-INF/blueprint/shell-diagnostic.xml b/diagnostic/command/src/main/resources/OSGI-INF/blueprint/shell-diagnostic.xml index b14434f..dcb3bb4 100644 --- a/diagnostic/command/src/main/resources/OSGI-INF/blueprint/shell-diagnostic.xml +++ b/diagnostic/command/src/main/resources/OSGI-INF/blueprint/shell-diagnostic.xml @@ -27,7 +27,6 @@ </command> </command-bundle> - <reference-list id="providers" interface="org.apache.karaf.diagnostic.core.DumpProvider" availability="optional"> </reference-list> http://git-wip-us.apache.org/repos/asf/karaf/blob/9da61ba1/diagnostic/common/src/main/java/org/apache/karaf/diagnostic/common/HeapDumpProvider.java ---------------------------------------------------------------------- diff --git a/diagnostic/common/src/main/java/org/apache/karaf/diagnostic/common/HeapDumpProvider.java b/diagnostic/common/src/main/java/org/apache/karaf/diagnostic/common/HeapDumpProvider.java index e41627d..3094c5e 100644 --- a/diagnostic/common/src/main/java/org/apache/karaf/diagnostic/common/HeapDumpProvider.java +++ b/diagnostic/common/src/main/java/org/apache/karaf/diagnostic/common/HeapDumpProvider.java @@ -19,6 +19,8 @@ package org.apache.karaf.diagnostic.common; import com.sun.management.HotSpotDiagnosticMXBean; import org.apache.karaf.diagnostic.core.DumpDestination; import org.apache.karaf.diagnostic.core.DumpProvider; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import javax.management.MBeanServer; import java.io.File; @@ -31,6 +33,8 @@ import java.lang.management.ManagementFactory; */ public class HeapDumpProvider implements DumpProvider { + private final static Logger LOGGER = LoggerFactory.getLogger(HeapDumpProvider.class); + public void createDump(DumpDestination destination) throws Exception { FileInputStream in = null; OutputStream out = null; @@ -52,7 +56,7 @@ public class HeapDumpProvider implements DumpProvider { heapDumpFile.delete(); } } catch (Exception e) { - // nothing to do + LOGGER.warn("Can't create heapdump", e); } finally { if (in != null) { in.close();
