Repository: karaf
Updated Branches:
  refs/heads/karaf-4.1.x be9e2719e -> ef8b9a312


[KARAF-5207] Features 1.4 namespace not supported by the features deployer

Project: http://git-wip-us.apache.org/repos/asf/karaf/repo
Commit: http://git-wip-us.apache.org/repos/asf/karaf/commit/ef8b9a31
Tree: http://git-wip-us.apache.org/repos/asf/karaf/tree/ef8b9a31
Diff: http://git-wip-us.apache.org/repos/asf/karaf/diff/ef8b9a31

Branch: refs/heads/karaf-4.1.x
Commit: ef8b9a312d6b2c5347c3f9c809ca2e63e6aea387
Parents: be9e271
Author: Guillaume Nodet <[email protected]>
Authored: Thu Jun 15 11:21:15 2017 +0200
Committer: Guillaume Nodet <[email protected]>
Committed: Thu Jun 15 11:31:31 2017 +0200

----------------------------------------------------------------------
 .../features/FeatureDeploymentListener.java     | 25 +++++---------------
 .../karaf/features/FeaturesNamespaces.java      |  5 ++++
 2 files changed, 11 insertions(+), 19 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/karaf/blob/ef8b9a31/deployer/features/src/main/java/org/apache/karaf/deployer/features/FeatureDeploymentListener.java
----------------------------------------------------------------------
diff --git 
a/deployer/features/src/main/java/org/apache/karaf/deployer/features/FeatureDeploymentListener.java
 
b/deployer/features/src/main/java/org/apache/karaf/deployer/features/FeatureDeploymentListener.java
index 2220b38..ab80236 100644
--- 
a/deployer/features/src/main/java/org/apache/karaf/deployer/features/FeatureDeploymentListener.java
+++ 
b/deployer/features/src/main/java/org/apache/karaf/deployer/features/FeatureDeploymentListener.java
@@ -101,27 +101,14 @@ public class FeatureDeploymentListener implements 
ArtifactUrlTransformer, Bundle
 
     private boolean isKnownFeaturesURI(String uri){
        if(uri == null){
-               return true;
+               return false;
        }
-       if(FeaturesNamespaces.URI_0_0_0.equalsIgnoreCase(uri)){
-               return true;
-       }
-       if(FeaturesNamespaces.URI_1_0_0.equalsIgnoreCase(uri)){
-               return true;
-       }
-       if(FeaturesNamespaces.URI_1_1_0.equalsIgnoreCase(uri)){
-               return true;
-       }
-        if(FeaturesNamespaces.URI_1_2_0.equalsIgnoreCase(uri)){
-            return true;
-        }
-        if(FeaturesNamespaces.URI_1_3_0.equalsIgnoreCase(uri)){
-            return true;
+       for (String ns : FeaturesNamespaces.SUPPORTED_URIS) {
+            if (ns.equalsIgnoreCase(uri)){
+                return true;
+            }
         }
-       if(FeaturesNamespaces.URI_CURRENT.equalsIgnoreCase(uri)){
-               return true;
-       }
-       return false;
+        return false;
     }
 
     private void loadProperties() throws IOException {

http://git-wip-us.apache.org/repos/asf/karaf/blob/ef8b9a31/features/core/src/main/java/org/apache/karaf/features/FeaturesNamespaces.java
----------------------------------------------------------------------
diff --git 
a/features/core/src/main/java/org/apache/karaf/features/FeaturesNamespaces.java 
b/features/core/src/main/java/org/apache/karaf/features/FeaturesNamespaces.java
index 48237a8..f05f0b9 100644
--- 
a/features/core/src/main/java/org/apache/karaf/features/FeaturesNamespaces.java
+++ 
b/features/core/src/main/java/org/apache/karaf/features/FeaturesNamespaces.java
@@ -33,6 +33,11 @@ public interface FeaturesNamespaces {
 
     String URI_CURRENT = URI_1_4_0;
 
+    String[] SUPPORTED_URIS = {
+            URI_1_0_0, URI_1_1_0, URI_1_2_0, URI_1_2_1,
+            URI_1_3_0, URI_1_4_0
+    };
+
     QName FEATURES_0_0_0 = new QName("features");
     QName FEATURES_1_0_0 = new QName(URI_1_0_0, "features");
     QName FEATURES_1_1_0 = new QName(URI_1_1_0, "features");

Reply via email to