oliverlietz commented on a change in pull request #1346:
URL: https://github.com/apache/karaf/pull/1346#discussion_r627345448
##########
File path: util/pom.xml
##########
@@ -74,6 +74,13 @@
<artifactId>mail</artifactId>
<scope>test</scope>
</dependency>
+ <!-- nullability -->
+ <dependency>
+ <groupId>org.jetbrains</groupId>
+ <artifactId>annotations</artifactId>
Review comment:
In general I prefer to annotate parameters and return values but the
dependency is of course not strictly required. The annotations
(https://github.com/JetBrains/java-annotations) are used during analysis and
compile time only and should have no negative impact.
Should I remove the annotations from ConfigurationPID?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
