mattrpav commented on PR #1884: URL: https://github.com/apache/karaf/pull/1884#issuecomment-2474150093
> @mattrpav I see a use case: a command use a service which starts a thread. The service has to be hook with ssh session to stop the thread when the session disconnects. So the service is not a shell command but it has to clean resources sync with ssh session. SCR deactivate is a hook on SCR component lifecycle not the ssh session. What about simply implementing the JDK's Closable and follow a convention vs marking with a domain-specific interface? Seems like (commandInstance instanceof Closeable) would do the trick and we wouldn't need to create a new interface. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
