stataru8 commented on PR #1863: URL: https://github.com/apache/karaf/pull/1863#issuecomment-2488881842
I see some duplicate code in `jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/PropertiesBackingEngine.java` and `jaas/modules/src/main/java/org/apache/karaf/jaas/modules/publickey/PublickeyBackingEngine.java`. Should we take this opportunity to refactor? Is it safe to do so? I was thinking of creating a parent class named `AbstractPropertiesBackingEngine` or `FileBasedBackingEngine`... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
