CptBartender commented on code in PR #2981:
URL: https://github.com/apache/karaf/pull/2981#discussion_r4211678132
##########
itests/test/src/test/java/org/apache/karaf/itests/WebTest.java:
##########
@@ -119,4 +125,12 @@ public void installViaMBean() throws Exception {
assertContains("Hello World!", buffer.toString());
}
+ private void waitForMBean(MBeanServer mbeanServer, ObjectName name) throws
InterruptedException {
+ long deadline = System.currentTimeMillis() + 30000;
+ while (!mbeanServer.isRegistered(name) && System.currentTimeMillis() <
deadline) {
+ Thread.sleep(500);
Review Comment:
This uses active waiting - replacing this with async calls would make it
less readable but may allow us to run the unit tests concurrently. Your
thoughts on this tradeoff?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
