MrEasy commented on code in PR #2214:
URL: https://github.com/apache/karaf/pull/2214#discussion_r4302129042


##########
assemblies/features/base/src/main/filtered-resources/resources/bin/karaf.bat:
##########
@@ -234,7 +234,7 @@ for /f tokens^=2-5^ delims^=.-_+^" %%j in ('"%JAVA%" 
-fullversion 2^>^&1') do (
     if %%j==1 (set JAVA_VERSION=%%k) else (set JAVA_VERSION=%%j)
 )
 
-if %JAVA_VERSION% GTR 8 (
+if "%JAVA_VERSION%" GTR 8 (

Review Comment:
   sure adding the % is desired? 
   Because on main it was 'explained' by Claude that it should be the opposite:
   - 
https://github.com/apache/karaf/commit/e306108e642005047afdfffdbfb6c64455218b45



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to