jbonofre opened a new pull request, #3087:
URL: https://github.com/apache/karaf/pull/3087

   Follow-up to #2994, which pinned `maven-compiler-plugin` and 
`maven-resources-plugin` in the karaf-maven-plugin ITs because Maven 4 resolves 
unpinned plugins to 4.0.0 betas that fail against the RC API with 
`NoSuchMethodError`.
   
   That fix only partly covered the problem:
   
   - **`maven-surefire-plugin` and `maven-install-plugin`**: the `bundle` 
packaging lifecycle from maven-bundle-plugin also binds `surefire:test` and 
`install:install` without a version, so both are still resolved from repository 
metadata, and `maven-install-plugin` already has 4.0.0 beta releases. Both are 
now pinned in the same `pluginManagement` blocks, using the 
`version.maven-surefire-plugin` and `version.maven-install-plugin` properties 
from the Apache parent, as #2994 does for the other two.
   - **`maven-bundle-plugin`**: it was declared as a build extension without a 
version in 11 IT poms, so those ITs always ran against its latest release. They 
are now pinned to `felix.maven-bundle-plugin.version`, the version Karaf itself 
builds with. Declarations that already set an explicit version (2.3.7, 2.5.4, 
3.0.1) are left unchanged.
   
   This also helps the Maven 4 work in #2214.
   
   ### Testing
   
   `mvn -pl tooling/karaf-maven-plugin clean verify` on JDK 17 / Maven 3.10.0: 
22/22 ITs pass in both the `integration-test` and `test-offline` invoker 
executions. The IT build logs show surefire 3.6.0 and maven-bundle-plugin 6.0.2 
being used where they are now pinned, and no unfiltered `@...@` tokens are left 
in the cloned poms.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to