holgerfriedrich commented on code in PR #3088:
URL: https://github.com/apache/karaf/pull/3088#discussion_r4565960845


##########
examples/karaf-rest-example/karaf-rest-example-whiteboard/src/main/java/org/apache/karaf/examples/rest/whiteboard/BookingServiceRest.java:
##########
@@ -28,43 +29,52 @@
 import jakarta.ws.rs.Path;
 import jakarta.ws.rs.PathParam;
 import jakarta.ws.rs.Produces;
+import org.osgi.service.component.annotations.ServiceScope;
+import 
org.osgi.service.jakartars.whiteboard.annotations.RequireJakartarsWhiteboard;
+import org.osgi.service.jakartars.whiteboard.propertytypes.JSONRequired;
+import org.osgi.service.jakartars.whiteboard.propertytypes.JakartarsResource;
+import org.osgi.service.servlet.whiteboard.annotations.RequireHttpWhiteboard;
+
 import java.util.Collection;
 import java.util.HashMap;
 import java.util.Map;
 
-@Path("/booking")
-@Component(service = BookingServiceRest.class, property = { 
"osgi.jaxrs.resource=true" })
+@RequireHttpWhiteboard
+@RequireJakartarsWhiteboard
+@JSONRequired

Review Comment:
   `JSONRequired` seems to require a JSON extension to be registered to the 
whiteboard, GET returns empty. For the example, you may drop this line. 



##########
examples/karaf-rest-example/karaf-rest-example-whiteboard/src/main/java/org/apache/karaf/examples/rest/whiteboard/BookingServiceRest.java:
##########
@@ -28,43 +29,52 @@
 import jakarta.ws.rs.Path;
 import jakarta.ws.rs.PathParam;
 import jakarta.ws.rs.Produces;
+import org.osgi.service.component.annotations.ServiceScope;
+import 
org.osgi.service.jakartars.whiteboard.annotations.RequireJakartarsWhiteboard;
+import org.osgi.service.jakartars.whiteboard.propertytypes.JSONRequired;
+import org.osgi.service.jakartars.whiteboard.propertytypes.JakartarsResource;
+import org.osgi.service.servlet.whiteboard.annotations.RequireHttpWhiteboard;
+
 import java.util.Collection;
 import java.util.HashMap;
 import java.util.Map;
 
-@Path("/booking")
-@Component(service = BookingServiceRest.class, property = { 
"osgi.jaxrs.resource=true" })
+@RequireHttpWhiteboard
+@RequireJakartarsWhiteboard
+@JSONRequired
+@JakartarsResource
+@Component(service = BookingServiceRest.class, scope = ServiceScope.PROTOTYPE)

Review Comment:
   ```suggestion
   @Component(service = BookingServiceRest.class)
   ```
   Removing `scope = ServiceScope.PROTOTYPE` should make a PUT/GET sequence 
working.



##########
examples/karaf-rest-example/karaf-rest-example-whiteboard/src/main/java/org/apache/karaf/examples/rest/whiteboard/BookingServiceRest.java:
##########
@@ -28,43 +29,52 @@
 import jakarta.ws.rs.Path;
 import jakarta.ws.rs.PathParam;
 import jakarta.ws.rs.Produces;
+import org.osgi.service.component.annotations.ServiceScope;
+import 
org.osgi.service.jakartars.whiteboard.annotations.RequireJakartarsWhiteboard;
+import org.osgi.service.jakartars.whiteboard.propertytypes.JSONRequired;
+import org.osgi.service.jakartars.whiteboard.propertytypes.JakartarsResource;
+import org.osgi.service.servlet.whiteboard.annotations.RequireHttpWhiteboard;
+
 import java.util.Collection;
 import java.util.HashMap;
 import java.util.Map;
 
-@Path("/booking")
-@Component(service = BookingServiceRest.class, property = { 
"osgi.jaxrs.resource=true" })
+@RequireHttpWhiteboard

Review Comment:
   ```suggestion
   @Path("/")
   @RequireHttpWhiteboard
   ```
   `Path("/")` annotation seems necessary to have a root resource.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to