MarianMacik commented on code in PR #224: URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/224#discussion_r1336130797
########## bddframework/pkg/api/app/v1beta1/groupversion_info.go: ########## @@ -0,0 +1,42 @@ +// Copyright 2020 Red Hat, Inc. and/or its affiliates +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// Package v1beta1 contains API Schema definitions for the app v1beta1 API group +// +kubebuilder:object:generate=true +// +groupName=app.kiegroup.org +package v1beta1 + +import ( + "k8s.io/apimachinery/pkg/runtime/schema" + "sigs.k8s.io/controller-runtime/pkg/scheme" +) + +var ( + // GroupVersion is group version used to register these objects + GroupVersion = schema.GroupVersion{Group: "app.kiegroup.org", Version: "v1beta1"} Review Comment: Well, my initial thought was that if in future we are going to use some kind of supporting services like we used to in Kogito (be it Data Index, UI or whatever), this may be a good starting point in tests to reuse those steps and just repurpose these structs. But yes, those are project-specific, so before extracting the whole framework to a separate repository we could first move them under the `testbdd` module or simply remove them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
