jstastny-cz commented on code in PR #1097:
URL:
https://github.com/apache/incubator-kie-kogito-pipelines/pull/1097#discussion_r1341082942
##########
dsl/seed/src/main/groovy/org/kie/jenkins/jobdsl/KogitoJobTemplate.groovy:
##########
@@ -490,17 +490,17 @@ class KogitoJobTemplate {
checkoutCredentialsId(Utils.getGitAuthorCredsId(script))
scanCredentialsId(Utils.getGitAuthorCredsId(script))
// Build fork PRs (unmerged head).
- buildForkPRHead(false)
+ buildForkPRHead(true)
// Build fork PRs (merged with base branch).
- buildForkPRMerge(true)
+ buildForkPRMerge(false)
Review Comment:
This would run PR checks without latest commits added in target branch. Just
noting it's gonna be important consideration when assessing check results.
##########
dsl/seed/src/main/groovy/org/kie/jenkins/jobdsl/KogitoJobTemplate.groovy:
##########
@@ -490,17 +490,17 @@ class KogitoJobTemplate {
checkoutCredentialsId(Utils.getGitAuthorCredsId(script))
scanCredentialsId(Utils.getGitAuthorCredsId(script))
// Build fork PRs (unmerged head).
- buildForkPRHead(false)
+ buildForkPRHead(true)
// Build fork PRs (merged with base branch).
- buildForkPRMerge(true)
+ buildForkPRMerge(false)
// Build origin branches.
buildOriginBranch(false)
// Build origin branches also filed as PRs.
- buildOriginBranchWithPR(false)
+ buildOriginBranchWithPR(true)
Review Comment:
Wouldn't duplicate identification? That for a origin branch with PR the
checks would be triggered for both branch and PR ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
