fjtirado commented on code in PR #3242:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3242#discussion_r1345758790
##########
kogito-serverless-workflow/kogito-serverless-workflow-runtime/src/main/java/org/kie/kogito/serverless/workflow/WorkflowWorkItemHandler.java:
##########
@@ -48,10 +47,13 @@ public void executeWorkItem(KogitoWorkItem workItem,
KogitoWorkItemManager manag
protected static <V> V buildBody(Map<String, Object> params, Class<V>
clazz) {
for (Object obj : params.values()) {
if (obj != null && clazz.isAssignableFrom(obj.getClass())) {
+ logger.trace("Invoking workitemhandler with value {}", obj);
return clazz.cast(obj);
}
}
- return ObjectMapperFactory.get().convertValue(params, clazz);
+ V value = JsonObjectUtils.convertValue(params, clazz);
+ logger.trace("Invoking workitemhandler with value {}", value);
Review Comment:
Same here. Also, in some circumstances, JsonObjectUtils.converValue will be
faster than directly invoking Jackson converter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
