fjtirado commented on code in PR #3255:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3255#discussion_r1368743547
##########
jbpm/jbpm-flow/src/main/java/org/jbpm/workflow/instance/node/TimerNodeInstance.java:
##########
@@ -111,7 +117,19 @@ public String[] getEventTypes() {
@Override
public void triggerCompleted(boolean remove) {
- triggerCompleted(Node.CONNECTION_DEFAULT_TYPE, remove);
+ Exception e = new TimerExpiredException();
+ ExceptionScopeInstance esi = getExceptionScopeInstance(e);
Review Comment:
Just a picky one, wont be better to write
```suggestion
ExceptionScopeInstance esi = (ExceptionScopeInstance)
resolveContextInstance(ExceptionScope.EXCEPTION_SCOPE, e);
```
and avoid a method call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
