baldimir commented on PR #5562: URL: https://github.com/apache/incubator-kie-drools/pull/5562#issuecomment-1779404712
@lucamolteni I changed the BigDecimalArgumentCoercion class as discussed - I removed the typed class to a separate util class. Otherwise, based on my investigation, my fix should be correct. Please let me know if that is not correct and what is your suggestion then. Based on my observation, doing it in the AssignExprT is late, same with doing it in ReProcessRHSPhase. I tried to follow how you did it here https://github.com/apache/incubator-kie-drools/blob/0cc9229c54f036767c45381ad36ee980a0588d52/drools-model/drools-mvel-compiler/src/main/java/org/drools/mvelcompiler/RHSPhase.java#L256. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
