radtriste commented on code in PR #1116:
URL:
https://github.com/apache/incubator-kie-kogito-pipelines/pull/1116#discussion_r1381831359
##########
dsl/scripts/pr_check.groovy:
##########
@@ -90,6 +90,7 @@ void launchStages() {
new MavenCommand(this)
.withProperty('sonar.login', "${TOKEN}")
.withProperty('sonar.organization', 'apache')
// override what's in pom.xml for now
+ .withProperty('sonar.projectKey',
env.SONAR_PROJECT_KEY)
Review Comment:
What happens if that env is not configured ?
##########
dsl/scripts/pr_check.groovy:
##########
@@ -90,6 +90,7 @@ void launchStages() {
new MavenCommand(this)
.withProperty('sonar.login', "${TOKEN}")
.withProperty('sonar.organization', 'apache')
// override what's in pom.xml for now
+ .withProperty('sonar.projectKey',
env.SONAR_PROJECT_KEY)
Review Comment:
What happens if that env is not configured ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
