mariofusco commented on code in PR #5574:
URL:
https://github.com/apache/incubator-kie-drools/pull/5574#discussion_r1382884807
##########
drools-compiler/src/main/java/org/drools/compiler/rule/builder/dialect/java/parser/JavaLexer.java:
##########
@@ -21,5206 +21,5226 @@
package org.drools.compiler.rule.builder.dialect.java.parser;
-import org.antlr.runtime.*;
+import org.antlr.runtime.BaseRecognizer;
+import org.antlr.runtime.CharStream;
+import org.antlr.runtime.CommonToken;
+import org.antlr.runtime.DFA;
+import org.antlr.runtime.EarlyExitException;
+import org.antlr.runtime.FailedPredicateException;
+import org.antlr.runtime.Lexer;
+import org.antlr.runtime.MismatchedSetException;
+import org.antlr.runtime.NoViableAltException;
+import org.antlr.runtime.RecognitionException;
+import org.antlr.runtime.RecognizerSharedState;
@SuppressWarnings("all")
public class JavaLexer extends Lexer {
Review Comment:
This is a generated source file and then I don't think it makes sense to
edit and reformat it. I don't consider this a blocker to merge this PR, but the
only problem is that all these changes will be necessarily overridden if for
any reason we will have to regenerate this file through antlr3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
