fjtirado commented on code in PR #3250:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3250#discussion_r1383101712


##########
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-integration-test/src/main/resources/callback-state-with-timeouts-error-handler.sw.json:
##########
@@ -70,7 +71,7 @@
         }
       ],
       "timeouts": {
-        "eventTimeout": "PT5S"
+        "eventTimeout": "$CONST.duration"

Review Comment:
   You are right in general (specially for existing examples), but in this 
particular test case (not an example, but an IT), there is not need to 
duplicate the flow because there are already other flows using hardcoded 
duration. In fact, the test want to ensure that using an expression in an 
existing timeout test does not break the test. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to