tkobayas commented on PR #5576: URL: https://github.com/apache/incubator-kie-drools/pull/5576#issuecomment-1797677238
Hi @mariofusco I sent https://github.com/mariofusco/drools/pull/22 to fix the test failure. Actually, Sudoku example uses `drools.halt()` to stop the evaluation. The test case can be fixed with the above PR, but the Sudoku example itself is not yet fixed, because it's a little more complicated, so it would require another kie-issue to fix the Sudoku example (With your PR, Sudoku immediately displays a full answer. "Step" button doesn't work). That said, this looks like a little breaking change. Some users may be affected, but I guess it's a very minor use case, so maybe okay to go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
