jstastny-cz commented on code in PR #1709:
URL:
https://github.com/apache/incubator-kie-kogito-images/pull/1709#discussion_r1386232839
##########
.ci/jenkins/dsl/jobs.groovy:
##########
@@ -59,7 +59,7 @@ void setupPrJob() {
}
void createSetupBranchJob() {
- def jobParams = JobParamsUtils.getBasicJobParams(this, 'kogito-images',
JobType.SETUP_BRANCH, "${jenkins_path}/Jenkinsfile.setup-branch", 'Kogito
Images Init Branch')
+ def jobParams = JobParamsUtils.getBasicJobParams(this, 'kogito-images-pr',
JobType.SETUP_BRANCH, "${jenkins_path}/Jenkinsfile.setup-branch", 'Kogito
Images Init Branch')
Review Comment:
This is setup-branch job variant, not relevant to PR checks, need to revert
the change.
##########
.ci/jenkins/dsl/jobs.groovy:
##########
@@ -40,7 +40,7 @@ setupQuarkusUpdateJob()
void setupPrJob() {
setupBuildImageJob(JobType.PULL_REQUEST)
- def jobParams = JobParamsUtils.getBasicJobParams(this, 'kogito-images',
JobType.PULL_REQUEST, "${jenkins_path}/Jenkinsfile", "Kogito Images PR check")
+ def jobParams = JobParamsUtils.getBasicJobParams(this, 'kogito-images-pr',
JobType.PULL_REQUEST, "${jenkins_path}/Jenkinsfile", "Kogito Images PR check")
Review Comment:
this actually was the old job, I think setupPrJob method is not called
elsewhere. What we should do instead is to focus on the setupBuildImageJob -
that's the job doing the actual stuff. I believe .ci/jenkins/Jenkinsfile then
triggers the build job.
##########
.ci/jenkins/dsl/jobs.groovy:
##########
@@ -255,7 +255,7 @@ void setupPromoteJob(JobType jobType) {
}
void setupQuarkusUpdateJob() {
- KogitoJobUtils.createQuarkusUpdateToolsJob(this, 'kogito-images', [:],
[:], [], [
- "source ~/virtenvs/cekit/bin/activate && python3
scripts/update-repository.py --quarkus-platform-version %new_version%"
+ KogitoJobUtils.createQuarkusUpdateToolsJob(this, 'kogito-images-pr', [:],
[:], [], [
Review Comment:
This is again a different job, we need to revert the change of name (python
change below should be fine).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
