This is an automated email from the ASF dual-hosted git repository. kbowers pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-kie-kogito-benchmarks.git
commit a19f0f4ac17c85bec52044a69884686b57b7ee8f Author: Marián Macik <[email protected]> AuthorDate: Fri Jul 2 17:05:16 2021 +0200 BAQE-1915 - Go over TODOs and ask Karm about some parts of the code --- .../src/main/java/org/kie/kogito/benchmarks/framework/Commands.java | 3 +-- .../src/test/java/org/kie/kogito/benchmarks/AbstractTemplateTest.java | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/kogito-benchmarks-framework/src/main/java/org/kie/kogito/benchmarks/framework/Commands.java b/kogito-benchmarks-framework/src/main/java/org/kie/kogito/benchmarks/framework/Commands.java index b2966d5..8a788a6 100644 --- a/kogito-benchmarks-framework/src/main/java/org/kie/kogito/benchmarks/framework/Commands.java +++ b/kogito-benchmarks-framework/src/main/java/org/kie/kogito/benchmarks/framework/Commands.java @@ -438,8 +438,7 @@ public class Commands { * 3.473028811 seconds time elapsed */ - // TODO Ask Karm about this - public static void processStopper(Process p, boolean force) throws InterruptedException, IOException { + public static void processStopper(Process p, boolean force) throws InterruptedException { p.children().forEach(child -> { if (child.supportsNormalTermination()) { child.destroy(); diff --git a/kogito-benchmarks-tests/src/test/java/org/kie/kogito/benchmarks/AbstractTemplateTest.java b/kogito-benchmarks-tests/src/test/java/org/kie/kogito/benchmarks/AbstractTemplateTest.java index 329dad8..3763365 100644 --- a/kogito-benchmarks-tests/src/test/java/org/kie/kogito/benchmarks/AbstractTemplateTest.java +++ b/kogito-benchmarks-tests/src/test/java/org/kie/kogito/benchmarks/AbstractTemplateTest.java @@ -116,7 +116,6 @@ public abstract class AbstractTemplateTest { runLogA = runInfo.getRunLog(); logger.info("Terminate and scan logs..."); - pA.getInputStream().available(); // TODO Ask Karm long rssKb = getRSSkB(pA.pid()); long openedFiles = getOpenedFDs(pA.pid()); --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
