tchughesiv commented on code in PR #283:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/283#discussion_r1391197784
##########
utils/kubernetes/deployment.go:
##########
@@ -111,6 +111,21 @@ func GetContainerByName(name string, podSpec *v1.PodSpec)
(*v1.Container, int) {
return nil, -1
}
+// GetContainerPortByName returns a pointer to the ContainerPort within the
given Container.
+// If none found, returns nil.
+// It also returns the position where the container port was found, -1 if none.
+func GetContainerPortByName(name string, container *v1.Container)
(*v1.ContainerPort, int) {
+ if container == nil {
Review Comment:
definitely understand the approach, but i should have noticed this pattern
being used in the existing functions... my bad. was just a nit anyway. lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
