wmedvede commented on code in PR #1924:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/1924#discussion_r1410416312
##########
data-index/data-index-service/data-index-service-common/src/main/java/org/kie/kogito/index/service/messaging/KogitoIndexEventConverter.java:
##########
@@ -118,6 +123,12 @@ public Message<?> convert(Message<?> message, Type type) {
}
}
+ private ProcessDefinitionDataEvent buildProcessDefinitionEvent(CloudEvent
cloudEvent) throws IOException {
Review Comment:
Sorry for being picky, but I think the introduction of this new event type
deserves augmenting the tests in KogitoIndexEventConverterTest, so we can be
sure the new event type conversion works well both for the binary and
structured mode. Specially if we consider the last issues we had when the
binary mode was arbitrary removed. Can you please add them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
