caponetto commented on code in PR #2092:
URL:
https://github.com/apache/incubator-kie-tools/pull/2092#discussion_r1423722922
##########
packages/kn-plugin-workflow/pkg/command/deploy.go:
##########
@@ -35,20 +35,35 @@ func NewDeployCommand() *cobra.Command {
Use: "deploy",
Short: "Deploy a SonataFlow project on Kubernetes via
SonataFlow Operator",
Long: `
- Deploy a SonataFlow project in Kubernetes via the SonataFlow Operator.
+ Deploy a SonataFlow project in Kubernetes via the SonataFlow Operator.
+ By default, the deploy command will generate the Operator manifests and
apply them to the cluster.
+ You can also provide a custom manifest directory with the
--custom-manifests-dir option.
`,
Example: `
# Deploy the workflow project from the current directory's project.
# You must provide target namespace.
{{.Name}} deploy --namespace <your_namespace>
+
# Persist the generated Operator manifests on a given path and deploy
the
# workflow from the current directory's project.
- {{.Name}} deploy --manifestPath=<full_directory_path>
- # Specify a custom support files folder.
- {{.Name}} deploy --supportFiles=<full_directory_path>
+ {{.Name}} deploy --custom-generated-manifests-dir=<full_directory_path>
+
+ # Specify a custom manifest files directory.
+ # This option *will not* automatically generate the manifest files, but
will use the existing ones.
+ {{.Name}} deploy --custom-manifests-dir=<full_directory_path>
+
+ # Specify a custom subflows files directory. (default: ./subflows)
+ {{.Name}} deploy --subflows-dir=<full_directory_path>
+
+ # Specify a custom support specs directory. (default: ./specs)
+ {{.Name}} deploy --specs-dir=<full_directory_path>
+
+ # Specify a custom support schemas directory. (default: ./schemas)
+ {{.Name}} deploy --schemas-dir=<full_directory_path>
+
`,
- PreRunE: common.BindEnv("namespace", "manifestPath",
"supportFilesFolder"),
+ PreRunE: common.BindEnv("namespace", "custom-manifests-dir",
"custom-generated-manifests-dir", "specs-dir", "schemas-dir", "subflows-dir"),
Review Comment:
Can we use constants for these names? It could be done in a separate PR but
I think it would be useful to extract these values into constants to avoid
mistakes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
