jordigilh commented on code in PR #311:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/311#discussion_r1424841769
##########
controllers/profiles/common/properties/application.go:
##########
@@ -27,46 +27,30 @@ import (
"strings"
"github.com/apache/incubator-kie-kogito-serverless-operator/controllers/discovery"
+
"github.com/apache/incubator-kie-kogito-serverless-operator/controllers/platform/services"
+
"github.com/apache/incubator-kie-kogito-serverless-operator/controllers/profiles/common/constants"
"github.com/magiconair/properties"
"k8s.io/klog/v2"
operatorapi
"github.com/apache/incubator-kie-kogito-serverless-operator/api/v1alpha08"
-
"github.com/apache/incubator-kie-kogito-serverless-operator/controllers/profiles"
"github.com/apache/incubator-kie-kogito-serverless-operator/log"
)
-const (
- ConfigMapWorkflowPropsVolumeName = "workflow-properties"
- kogitoServiceUrlProperty = "kogito.service.url"
- kogitoServiceUrlProtocol = "http"
- dataIndexServiceUrlProperty =
"mp.messaging.outgoing.kogito-processinstances-events.url"
- kafkaSmallRyeHealthProperty =
"quarkus.smallrye-health.check.\"io.quarkus.kafka.client.health.KafkaHealthCheck\".enabled"
- dataIndexServiceUrlProtocol = "http"
-
- DataIndexImageBase = "quay.io/kiegroup/kogito-data-index-"
- DataIndexName = "data-index-service"
-
- PersistenceTypeEphemeral = "ephemeral"
- PersistenceTypePostgressql = "postgresql"
-
- microprofileServiceCatalogPropertyPrefix =
"org.kie.kogito.addons.discovery."
- discoveryLikePropertyPattern =
"^\\${(kubernetes|knative|openshift):(.*)}$"
+var (
+ immutableApplicationProperties = fmt.Sprintf("quarkus.http.port=%d\n"+
+ "quarkus.http.host=0.0.0.0\n"+
+ // We disable the Knative health checks to not block the dev
pod to run if Knative objects are not available
+ // See:
https://kiegroup.github.io/kogito-docs/serverlessworkflow/latest/eventing/consume-produce-events-with-knative-eventing.html#ref-knative-eventing-add-on-source-configuration
+ "org.kie.kogito.addons.knative.eventing.health-enabled=false\n"+
+ "quarkus.devservices.enabled=false\n"+
+ "quarkus.kogito.devservices.enabled=false\n",
constants.DefaultHTTPWorkflowPortInt)
+
+ discoveryLikePropertyExpr =
regexp.MustCompile(constants.DiscoveryLikePropertyPattern)
Review Comment:
Done, moved constant to this file and made it private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
