ricardozanini commented on code in PR #311:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/311#discussion_r1425490421
##########
controllers/profiles/common/properties/application.go:
##########
@@ -143,31 +131,18 @@ func (a *appPropertyHandler) Build() string {
func (a *appPropertyHandler) withKogitoServiceUrl() AppPropertyHandler {
var kogitoServiceUrl string
if len(a.workflow.Namespace) > 0 {
- kogitoServiceUrl = fmt.Sprintf("%s://%s.%s",
kogitoServiceUrlProtocol, a.workflow.Name, a.workflow.Namespace)
+ kogitoServiceUrl = fmt.Sprintf("%s://%s.%s",
constants.KogitoServiceUrlProtocol, a.workflow.Name, a.workflow.Namespace)
} else {
- kogitoServiceUrl = fmt.Sprintf("%s://%s",
kogitoServiceUrlProtocol, a.workflow.Name)
+ kogitoServiceUrl = fmt.Sprintf("%s://%s",
constants.KogitoServiceUrlProtocol, a.workflow.Name)
}
- return a.addDefaultMutableProperty(kogitoServiceUrlProperty,
kogitoServiceUrl)
-}
-
-// withDataIndexServiceUrl adds the property dataIndexServiceUrlProperty to
the application properties.
-// See Service Discovery
https://kubernetes.io/docs/concepts/services-networking/service/#dns
-func (a *appPropertyHandler) withDataIndexServiceUrl() AppPropertyHandler {
- if profiles.IsProdProfile(a.workflow) && dataIndexEnabled(a.platform) {
Review Comment:
Only workflows not in `dev` profile in the given `SonataFlowPlatform` should
be configured to communicate with Jobs Service and Data Index.
This is the use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
