tkobayas commented on code in PR #5623:
URL:
https://github.com/apache/incubator-kie-drools/pull/5623#discussion_r1426506899
##########
drools-base/src/main/java/org/drools/base/util/index/IndexUtil.java:
##########
@@ -62,7 +62,7 @@ public static boolean
compositeAllowed(BetaNodeFieldConstraint[] constraints, sh
}
public static boolean isIndexable(BetaNodeFieldConstraint constraint,
short nodeType, KieBaseConfiguration config) {
- return constraint instanceof IndexableConstraint &&
((IndexableConstraint)constraint).isIndexable(nodeType, config);
+ return constraint instanceof IndexableConstraint &&
((IndexableConstraint)constraint).isIndexable(nodeType, config) &&
!isBigDecimalEqualityConstraint((IndexableConstraint)constraint);
Review Comment:
Usually, `IndexUtil.isEqualIndexable` checks the BigDecimal constraint. Only
ExistsNode and NotNode hit this problem, so `isIndexable` is also fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
