ricardozanini commented on code in PR #323:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/323#discussion_r1428002670
##########
.ci/jenkins/scripts/minikube.groovy:
##########
@@ -100,8 +100,9 @@ void preChecks() {
${minikubeContainerEngine} info
if [[ ! \$(command -v minikube) ]]; then
- curl -LO
https://github.com/kubernetes/minikube/releases/download/v${minikubeVersion}/minikube-${minikubeVersion}-0.x86_64.rpm
- sudo yum localinstall -y minikube-${minikubeVersion}-0.x86_64.rpm
+ curl -LO
https://github.com/kubernetes/minikube/releases/download/v${minikubeVersion}/minikube-linux-amd64
+ sudo cp minikube-linux-amd64 /usr/local/bin/minikube
+ sudo chmod 755 /usr/local/bin/minikube
Review Comment:
We have a script to do this, maybe it's worth reusing it?
https://github.com/apache/incubator-kie-kogito-serverless-operator/blob/main/hack/ci/install-minikube.sh
There we are able to fetch the correct minikube version based on the
platform, so we avoid hardcoding here. wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
