mariofusco opened a new pull request, #5634: URL: https://github.com/apache/incubator-kie-drools/pull/5634
This is a fix for the performance issue reported with [this comment](https://github.com/apache/incubator-kie-drools/pull/5621#issuecomment-1860946943). Running the same benchmark against this commit I got the following results ``` Benchmark (argsType) Mode Cnt Score Error Units FEELInfixOpBenchmark.eval String thrpt 10 4398.719 ± 12.653 ops/ms FEELInfixOpBenchmark.eval int thrpt 10 4303.348 ± 17.151 ops/ms ``` that are much better of the current situation but also around 20% faster than what we had on 8.44.0.Final that was ``` Benchmark (argsType) Mode Cnt Score Error Units FEELInfixOpBenchmark.eval String thrpt 10 3866.743 ± 30.992 ops/ms FEELInfixOpBenchmark.eval int thrpt 10 3367.492 ± 11.529 ops/ms ``` I believe that there is still room for improvement, but this seems a step in the right direction that however will need to be validated with more extensive benchmarks before being merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
