mdproctor commented on code in PR #5630:
URL:
https://github.com/apache/incubator-kie-drools/pull/5630#discussion_r1432631470
##########
drools-core/src/main/java/org/drools/core/phreak/PhreakAccumulateNode.java:
##########
@@ -141,7 +141,7 @@ private void doLeftInserts(AccumulateNode accNode,
BetaMemory bm = am.getBetaMemory();
TupleMemory ltm = bm.getLeftTupleMemory();
TupleMemory rtm = bm.getRightTupleMemory();
- ContextEntry[] contextEntry = bm.getContext();
+ Object contextEntry = bm.getContext();
Review Comment:
Note that in reality, with the flat PositionalConstraint, it doesn't
actually need a Context any more. But it was too much work to figure out how to
make that optional, but in a future release it might be nice.
##########
drools-core/src/main/java/org/drools/core/common/BetaConstraints.java:
##########
@@ -22,37 +22,36 @@
import java.util.List;
import org.drools.base.base.ObjectType;
-import org.drools.base.rule.ContextEntry;
+import org.drools.base.reteoo.BaseTuple;
import org.drools.base.rule.Pattern;
-import org.drools.base.rule.constraint.BetaNodeFieldConstraint;
+import org.drools.base.rule.constraint.BetaConstraint;
import org.drools.core.RuleBaseConfiguration;
import org.drools.core.reteoo.BetaMemory;
import org.drools.core.reteoo.Tuple;
import org.drools.core.reteoo.builder.BuildContext;
import org.drools.util.bitmask.BitMask;
import org.kie.api.runtime.rule.FactHandle;
-public interface BetaConstraints
+public interface BetaConstraints<C>
Review Comment:
Its not strictly necessary, but I found in a few places it avoided casts, so
less code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
