ljmotta commented on code in PR #2103:
URL:
https://github.com/apache/incubator-kie-tools/pull/2103#discussion_r1437314665
##########
.github/actions/setup-env/action.yml:
##########
@@ -97,6 +97,16 @@ runs:
colima start --memory 4 --network-address --verbose
# QEMU is reinstalled due to this bug:
https://github.com/lima-vm/lima/issues/1742
+ - name: "Setup Helm (Ubuntu)"
+ if: runner.os == 'Linux'
+ shell: bash
+ env:
+ HELM_VERSION: "v3.13.3"
+ run: |
+ echo "STEP: Install Helm (Ubuntu only)"
+ sudo wget -q https://get.helm.sh/helm-$HELM_VERSION-linux-amd64.tar.gz
-O - | tar -xzO linux-amd64/helm > /usr/local/bin/helm
+ sudo chmod +x /usr/local/bin/helm
Review Comment:
It's better to remove the tar.gz? or it doesn't make a difference here?
##########
packages/kie-sandbox-helm-chart/src/templates/NOTES.txt:
##########
@@ -0,0 +1,147 @@
+{{- if not .Values.global.ingressSource }}
+
+In order to get KIE sandbox running you need to run these commands:
Review Comment:
```suggestion
In order to get KIE Sandbox running you need to run these commands:
```
##########
packages/kie-sandbox-helm-chart/install.js:
##########
@@ -0,0 +1,17 @@
+const buildEnv = require("./env");
+const yaml = require("js-yaml");
+const fs = require("fs");
+
+const file = "src/Chart.yaml";
+const doc = yaml.load(fs.readFileSync(file, "utf8"));
+doc.version = buildEnv.env.kieSandboxHelmChart.tag;
Review Comment:
The dependencies version shouldn't be updated as well? Or updating the
`kie_sandbox_helm_chart` version will reflect on the dependencies?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
