mariofusco commented on code in PR #5639:
URL:
https://github.com/apache/incubator-kie-drools/pull/5639#discussion_r1438080628
##########
drools-model/drools-model-codegen/src/main/java/org/drools/model/codegen/execmodel/generator/Consequence.java:
##########
@@ -162,6 +163,8 @@ public MethodCallExpr createCall(String consequenceString,
BlockStmt ruleVariabl
MethodCallExpr executeCall;
switch (context.getRuleDialect()) {
+ case PROTOTYPE:
+ rewriteConsequenceForPrototype(ruleConsequence,
usedDeclarationInRHS);
case JAVA:
rewriteReassignedDeclarations(ruleConsequence,
usedDeclarationInRHS);
executeCall = executeCall(ruleVariablesBlock, ruleConsequence,
usedDeclarationInRHS, onCall);
Review Comment:
> FYI the accessors to map with the dot should be supported in MVEL as well
but it's not currently
Sorry I probably misread your comment and missed the fact that we do **not**
support this feature in MVEL dialect even if we should. If I can make it work
for prototypes I agree that it would be nice to generalize it also for MVEL
maps, but I believe that it would be better to implement this with a different
pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
