tiagobento commented on code in PR #2099:
URL:
https://github.com/apache/incubator-kie-tools/pull/2099#discussion_r1445012336
##########
packages/chrome-extension/src/app/components/common/customEffects.ts:
##########
@@ -27,7 +27,7 @@ export function useEffectAfterFirstRender(func: () =>
ReturnType<EffectCallback>
} else {
firstRender.current = false;
}
- }, deps);
+ }, [func]);
Review Comment:
Ahm, I don't think so. To be honest, I haven't done research on how we're
supposed to deal with custom hooks dependencies checks... but I guess it's okay
for specific cases like this if you ignore the warning with a ESLint directive
and provide a nice comment explaining that `deps` is an extension mechanism to
allow callers to define their own custom dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
