yurloc commented on issue #804: URL: https://github.com/apache/incubator-kie-issues/issues/804#issuecomment-1882686463
> Thanks @yurloc I personally disagree with usage of hardcoded values because, depending on the use cases, they tend to check only specific situations and miss other corner cases. In this particular situation, I'll check exactly what could be the problem I definitely recognize the need to cover various input data combinations and corner cases. I merely disagree with the current approach that relies on random chance to feed such data to the test. Hard-coding input data will make the test _deterministic_. Combining hard-coded values with `@ParametrizedTest` will allow the test to cover multiple input data, including various corner cases, while keeping it deterministic. Anyway, removing randomness is just a suggestion, not the primary focus of this issue. The main goal here is to fix the bug due to which 0 is sometimes being passed to `Random.nextInt()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
