jakubschwan commented on code in PR #344:
URL: 
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/344#discussion_r1446242953


##########
test/builder/Dockerfile:
##########
@@ -32,7 +32,7 @@ RUN ${MAVEN_HOME}/bin/mvn -U -B ${MAVEN_ARGS_APPEND} -s 
${MAVEN_SETTINGS_PATH} c
 #=============================
 # Runtime Run
 #=============================
-FROM registry.access.redhat.com/ubi8/openjdk-11:1.11
+FROM registry.access.redhat.com/ubi8/openjdk-17:1.18-2

Review Comment:
   ```suggestion
   FROM registry.access.redhat.com/ubi8/openjdk-17:1.18
   ```



##########
container-builder/builder/kubernetes/testdata/Dockerfile:
##########
@@ -32,7 +32,7 @@ RUN ${MAVEN_HOME}/bin/mvn -U -B ${MAVEN_ARGS_APPEND} -s 
${MAVEN_SETTINGS_PATH} c
 #=============================
 # Runtime Run
 #=============================
-FROM registry.access.redhat.com/ubi8/openjdk-11:1.11
+FROM registry.access.redhat.com/ubi8/openjdk-17:1.18-2

Review Comment:
   use abstract 1.18 tag instead of specific 1.18-2 , in case another 1.18 
build or CVE fix, the latest will be used and image up to date. 
   ```suggestion
   FROM registry.access.redhat.com/ubi8/openjdk-17:1.18
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to