jakubschwan commented on code in PR #338:
URL: 
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/338#discussion_r1447628437


##########
bundle/manifests/sonataflow-operator.clusterserviceversion.yaml:
##########
@@ -576,6 +576,22 @@ spec:
           - get
           - list
           - watch
+        - apiGroups:
+          - apps.openshift.io
+          resources:
+          - deploymentconfigs

Review Comment:
   Do we want to add resources and discovery for deplyomentconfig? As of 
OpenShift Container Platform 4.14, DeploymentConfig objects are deprecated. 
   Also if I understand it is only used to find the catalogs, right. In that 
case I think it would be better to use CatalogSource resource instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to